Fix Vulkan validation errors #92

Merged
Ghost merged 7 commits from AsperTheDog/Ryubing:fix-validation-errors into master 2026-05-15 15:36:15 +00:00
Contributor

This PR fixes several validation errors caused by invalid Vulkan usage. These validation errors often end up invoking Undefined Behavior on the driver side, which can lead to artifacts or crashes which are driver specific and otherwise incredibly hard to track. I don't think it should have any impact on performance, but it would be good to test it with as many games as possible (maybe a bug in a game was fixed?).

Each commit fixes an error. I added to each a description with the validation error that was fixed and a small explanation on what was causing it and how I fixed it.

This PR fixes several validation errors caused by invalid Vulkan usage. These validation errors often end up invoking Undefined Behavior on the driver side, which can lead to artifacts or crashes which are driver specific and otherwise incredibly hard to track. I don't think it should have any impact on performance, but it would be good to test it with as many games as possible (maybe a bug in a game was fixed?). Each commit fixes an error. I added to each a description with the validation error that was fixed and a small explanation on what was causing it and how I fixed it.
Ghost force-pushed fix-validation-errors from d868d5d5f4
All checks were successful
Pull Request Triage / triage (pull_request_target) Successful in 13s
Build PR / linux-arm64 (Release) (pull_request) Successful in 4m28s
Build PR / win-x64 (Release) (pull_request) Successful in 8m56s
Build PR / macOS Universal (Release) (pull_request) Successful in 10m25s
Build PR / linux-x64 (Release) (pull_request) Successful in 18m15s
to a533996325
All checks were successful
Build PR / win-x64 (Release) (pull_request) Successful in 10m23s
Build PR / macOS Universal (Release) (pull_request) Successful in 10m36s
Build PR / linux-arm64 (Release) (pull_request) Successful in 9m4s
Build PR / linux-x64 (Release) (pull_request) Successful in 10m10s
2026-05-15 15:35:29 +00:00
Compare
Ghost merged commit 58bd19a2f3 into master 2026-05-15 15:36:15 +00:00
Ghost deleted branch fix-validation-errors 2026-05-15 15:36:17 +00:00
Ghost referenced this pull request from a commit 2026-05-15 15:36:17 +00:00
Ghost added this to the 1.4.0 milestone 2026-06-27 17:14:03 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
projects/Ryubing!92
No description provided.