projects/Ryubing
projects/Ryubing
Watch
3
10
Fork
You've already forked Ryubing
 36
Code Issues 1 Pull requests 16 Releases 3 Wiki Activity Actions 1

Fix Windows fullscreen gap when toggling from maximized #80

Merged
Ghost merged 2 commits from Babib3l/Ryubing:fix-windows-fullscreen-f11 into master 2026-05-10 23:47:40 +00:00
Conversation 1 Commits 2 Files changed 2 +82 -2
Babib3l commented 2026-05-06 12:12:01 +00:00
Contributor

This PR aims to Fix the Windows fullscreen gap when toggling from maximized state by using canonical Win32 fullscreen approach. When entering fullscreen, the window style is saved and replaced with WS_POPUP | WS_VISIBLE to remove all window chrome (title bar, borders), then SetWindowPos sizes the window to cover the full screen with SWP_FRAMECHANGED to force Win32 to recalculate the frame. On exit, the original window style is restored. This eliminates the few-pixel gap at the top that occurred because Avalonia's WindowState = FullScreen transition from a maximized state retained the title bar non-client area, leaving visible space at the top of the screen (Fullscreen resolution would be 1920 x 1072p on a 1080p monitor, it now correctly renders at 1920 x 1080p)

This PR aims to Fix the Windows fullscreen gap when toggling from maximized state by using canonical Win32 fullscreen approach. When entering fullscreen, the window style is saved and replaced with WS_POPUP | WS_VISIBLE to remove all window chrome (title bar, borders), then SetWindowPos sizes the window to cover the full screen with SWP_FRAMECHANGED to force Win32 to recalculate the frame. On exit, the original window style is restored. This eliminates the few-pixel gap at the top that occurred because Avalonia's WindowState = FullScreen transition from a maximized state retained the title bar non-client area, leaving visible space at the top of the screen (Fullscreen resolution would be 1920 x 1072p on a 1080p monitor, it now correctly renders at 1920 x 1080p)
Ghost requested changes 2026-05-06 12:18:47 +00:00
src/Ryujinx/UI/ViewModels/MainWindowViewModel.cs Outdated
@ -2041,0 +2067,4 @@
Win32NativeInterop.SetWindowLongPtrW(hwnd, Win32NativeInterop.GWL_STYLE,
unchecked((nint)(Win32NativeInterop.WS_POPUP | Win32NativeInterop.WS_VISIBLE)));
var screen = Window.Screens.ScreenFromVisual(Window);
Ghost commented 2026-05-06 12:14:30 +00:00

Can we specify the type here instead of using var?

Can we specify the type here instead of using ``var``?
Babib3l marked this conversation as resolved
Ghost force-pushed fix-windows-fullscreen-f11 from 25831e6e98
All checks were successful
Build PR / linux-arm64 (Release) (pull_request_target) Successful in 5m13s
Details
Build PR / macOS Universal (Release) (pull_request_target) Successful in 8m37s
Details
Build PR / linux-x64 (Release) (pull_request_target) Successful in 8m42s
Details
Build PR / win-x64 (Release) (pull_request_target) Successful in 8m58s
Details
Build PR / Post comment linking uploaded artifacts (pull_request_target) Successful in 4s
Details
to 811add944a
All checks were successful
Build PR / linux-arm64 (Release) (pull_request) Successful in 4m28s
Details
Build PR / linux-x64 (Release) (pull_request) Successful in 8m47s
Details
Build PR / win-x64 (Release) (pull_request) Successful in 8m49s
Details
Build PR / macOS Universal (Release) (pull_request) Successful in 9m1s
Details
2026-05-10 23:47:28 +00:00 Compare
Ghost merged commit bab160d650 into master 2026-05-10 23:47:40 +00:00
Ghost deleted branch fix-windows-fullscreen-f11 2026-05-10 23:47:40 +00:00
Ghost referenced this pull request from a commit 2026-05-25 12:09:01 +00:00
Windows Fullscreen Fixes (#87)
Ghost added this to the 1.4.0 milestone 2026-06-27 17:12:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Ghost
Labels
Clear labels   
audio
Relates to audio emulation.

  
bug
Unintended behavior.

  
confirmed
A verified issue.

  
cpu
Related to CPU translation, missing ARMeilleure instruction, or memory.

  
critical
An issue of high importance. Should be addressed ASAP.

  
development
Related to building, upgrading dependencies, logging, or quality-of-life improvements to the development process.

  
enhancement
A new feature or enhancement to an existing one.

  
gpu
Related to GPU emulation, the shared GPU code, shader translation, or GAL.

  
graphics-backend:opengl
Related to the OpenGL backend.

  
graphics-backend:vulkan
Related to the Vulkan backend.

  
gui
A UI problem or improvement.

  
help wanted
Additional help from a more experienced developer or reverse engineer is required.

  
horizon/hle
Related to Nintendo Switch HLE components. (Ryujinx.HLE and Ryujinx.Horizon)

  
i18n
Related to translation.

  
infra
Project infrastructure; dependencies, README changes, CI script changes, etc.

  
input
Related to controller input or configuration.

  
kernel
Related to Nintendo Switch kernel functionality implemented in the HLE and Horizon projects.

  
linux
Related to a Linux-specific issue or functionality, or the appimage build.

  
macos
Related to a macOS-specific issue or functionality.

  
suggestion
A suggestion or idea for improvement.

  
windows
Related to a Windows-specific issue or functionality.

No labels
audio
bug
confirmed
cpu
critical
development
enhancement
gpu
graphics-backend:opengl
graphics-backend:vulkan
gui
help wanted
horizon/hle
i18n
infra
input
kernel
linux
macos
suggestion
windows
Milestone
Clear milestone
No items
No milestone
1.4.0
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
projects/Ryubing!80
No description provided.