Fix Windows console hide path targeting the foreground window #32

Merged
Ghost merged 5 commits from Babib3l/Ryubing:fix-console-behaviour into master 2026-05-05 03:48:25 +00:00
Contributor

This PR addresses Ryubing/Issues#345 by fixing the Windows console hide/show path so it only acts on Ryujinx’s own console window instead of whatever window happens to be focused during startup. Previously, when Show Console was disabled, the helper could race with focus changes and end up affecting another app or shell window while leaving the console visible; this change removes that foreground-window dependency and keeps the startup behavior scoped to the Ryujinx console.

This PR addresses [Ryubing/Issues#345](https://github.com/Ryubing/Issues/issues/345) by fixing the Windows console hide/show path so it only acts on Ryujinx’s own console window instead of whatever window happens to be focused during startup. Previously, when Show Console was disabled, the helper could race with focus changes and end up affecting another app or shell window while leaving the console visible; this change removes that foreground-window dependency and keeps the startup behavior scoped to the Ryujinx console.
Babib3l force-pushed fix-console-behaviour from b79594493f
Some checks failed
Pull Request Triage / triage (pull_request_target) Successful in 13s
Build PR / linux-arm64 (Release) (pull_request) Has been cancelled
Build PR / linux-x64 (Release) (pull_request) Has been cancelled
Build PR / win-x64 (Release) (pull_request) Has been cancelled
Build PR / macOS Universal (Release) (pull_request) Has been cancelled
to c944e80cdc
All checks were successful
Build PR / linux-arm64 (Release) (pull_request) Successful in 4m34s
Build PR / win-x64 (Release) (pull_request) Successful in 6m25s
Build PR / linux-x64 (Release) (pull_request) Successful in 6m34s
Build PR / macOS Universal (Release) (pull_request) Successful in 12m48s
2026-04-24 11:32:19 +00:00
Compare
Author
Contributor

closed in favour of !33

closed in favour of !33
Babib3l closed this pull request 2026-04-24 15:23:13 +00:00
Babib3l reopened this pull request 2026-05-04 14:50:34 +00:00
Babib3l changed title from WIP : Fix Windows console hide path targeting the foreground window to Fix Windows console hide path targeting the foreground window 2026-05-04 17:52:08 +00:00
Ghost force-pushed fix-console-behaviour from 069214fb5c
All checks were successful
Build PR / win-x64 (Release) (pull_request) Successful in 8m48s
Build PR / linux-x64 (Release) (pull_request) Successful in 9m39s
Build PR / linux-arm64 (Release) (pull_request) Successful in 12m34s
Build PR / macOS Universal (Release) (pull_request) Successful in 14m35s
to fad575e93f
Some checks failed
Build PR / win-x64 (Release) (pull_request) Successful in 14m46s
Build PR / linux-x64 (Release) (pull_request) Successful in 17m39s
Build PR / macOS Universal (Release) (pull_request) Successful in 17m59s
Build PR / linux-arm64 (Release) (pull_request) Failing after 17m31s
Build PR / Post comment linking uploaded artifacts (pull_request) Has been skipped
2026-05-05 03:47:52 +00:00
Compare
Ghost merged commit 4d0cd61b6a into master 2026-05-05 03:48:25 +00:00
Ghost deleted branch fix-console-behaviour 2026-05-05 03:48:28 +00:00
Ghost added this to the 1.4.0 milestone 2026-06-27 17:11:09 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
projects/Ryubing!32
No description provided.