projects/Ryubing
projects/Ryubing
4
9
Fork
You've already forked Ryubing
 34
Code Issues 1 Pull requests 17 Releases 3 Wiki Activity Actions 7

HLE: CaptureManager: SaveScreenShot: properly handle screenshot image data #18

Merged
LotP merged 6 commits from Xam/Ryubing:shots into master 2026-04-17 23:08:34 +00:00
Conversation 0 Commits 6 Files changed 1 +5 -2
Xam commented 2026-04-17 17:57:43 +00:00
Contributor
Copy link

no way this was working before, and if it did, just pure luck, unsafe blind copy of bytes as is and zero checks.

i only tested tomodachi, but should fix all games that were crashing on saving screenshots

the crash was happening because the screenshot buffer was bigger than the bitmap buffer, so marshall.copy() was raising an unhandhled expection crashing the emu.

on top of this, because the data was just copied as is, the result image was garbled.

fixes #304

no way this was working before, and if it did, just pure luck, unsafe blind copy of bytes as is and zero checks. i only tested tomodachi, but should fix all games that were crashing on saving screenshots the crash was happening because the screenshot buffer was bigger than the bitmap buffer, so marshall.copy() was raising an unhandhled expection crashing the emu. on top of this, because the data was just copied as is, the result image was garbled. [fixes #304](https://github.com/Ryubing/Issues/issues/304)
LotP force-pushed shots from dd1de89c56
All checks were successful
Build PR / linux-arm64 (Release) (pull_request) Successful in 5m0s
Details
Build PR / win-x64 (Release) (pull_request) Successful in 5m58s
Details
Build PR / linux-x64 (Release) (pull_request) Successful in 7m1s
Details
Build PR / macOS Universal (Release) (pull_request) Successful in 12m29s
Details
to 8baad70ed8
All checks were successful
Build PR / linux-arm64 (Release) (pull_request) Successful in 5m48s
Details
Build PR / win-x64 (Release) (pull_request) Successful in 8m10s
Details
Build PR / linux-x64 (Release) (pull_request) Successful in 8m18s
Details
Build PR / macOS Universal (Release) (pull_request) Successful in 14m8s
Details
2026-04-17 23:07:57 +00:00 Compare
LotP merged commit 35b1531102 into master 2026-04-17 23:08:34 +00:00
ryuadmin added this to the 1.4.0 milestone 2026-05-05 00:35:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
audio
Relates to audio emulation.

  
bug
Unintended behavior.

  
confirmed
A verified issue.

  
cpu
Related to CPU translation, missing ARMeilleure instruction, or memory.

  
critical
An issue of high importance. Should be addressed ASAP.

  
development
Related to building, upgrading dependencies, logging, or quality-of-life improvements to the development process.

  
enhancement
A new feature or enhancement to an existing one.

  
gpu
Related to GPU emulation, the shared GPU code, shader translation, or GAL.

  
graphics-backend:opengl
Related to the OpenGL backend.

  
graphics-backend:vulkan
Related to the Vulkan backend.

  
gui
A UI problem or improvement.

  
help wanted
Additional help from a more experienced developer or reverse engineer is required.

  
horizon/hle
Related to Nintendo Switch HLE components. (Ryujinx.HLE and Ryujinx.Horizon)

  
i18n
Related to translation.

  
infra
Project infrastructure; dependencies, README changes, CI script changes, etc.

  
input
Related to controller input or configuration.

  
kernel
Related to Nintendo Switch kernel functionality implemented in the HLE and Horizon projects.

  
linux
Related to a Linux-specific issue or functionality, or the appimage build.

  
macos
Related to a macOS-specific issue or functionality.

  
suggestion
A suggestion or idea for improvement.

  
windows
Related to a Windows-specific issue or functionality.

No labels
audio
bug
confirmed
cpu
critical
development
enhancement
gpu
graphics-backend:opengl
graphics-backend:vulkan
gui
help wanted
horizon/hle
i18n
infra
input
kernel
linux
macos
suggestion
windows
Milestone
Clear milestone
No items
No milestone
1.4.0
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
projects/Ryubing!18
No description provided.