projects/Ryubing
projects/Ryubing
Watch
3
10
Fork
You've already forked Ryubing
 37
Code Issues 1 Pull requests 13 Releases 3 Wiki Activity Actions

Threaded Renderer Crash, Threaded Renderer Index Desync, Logger Disposal #174

Merged
LotP merged 4 commits from MabelAmber/Ryubing:lotps-fixes into master 2026-07-27 20:03:46 +00:00
Conversation 0 Commits 4 Files changed 2 +12 -3
MabelAmber commented 2026-07-27 03:50:18 +00:00
Contributor

These 3 are all fixes made by LotP, who said they just didn't feel like making the PR atm and that someone else could do it if they wanted to (https://discord.com/channels/1294443224030511104/1295891559056674816/1531034369232211968)

Addresses these 3 specific issues:

  1. Toggling the hidden console tries to assign a new console logger, which is also done on setting initial state, but at that point a logger already exists so it just returns, except previously it did not dispose of the new logger.
  2. The threaded renderer would sometimes just crash when emulation is stopped, the fix being to make sure the backend render thread is joined before touching common objects
  3. The disposing workflow of other threads than the main GPU adds commands to the command queue, causing a problem where the index can get desynced because of race conditions
These 3 are all fixes made by LotP, who said they just didn't feel like making the PR atm and that someone else could do it if they wanted to (https://discord.com/channels/1294443224030511104/1295891559056674816/1531034369232211968) Addresses these 3 specific issues: 1. Toggling the hidden console tries to assign a new console logger, which is also done on setting initial state, but at that point a logger already exists so it just returns, except previously it did not dispose of the new logger. 2. The threaded renderer would sometimes just crash when emulation is stopped, the fix being to make sure the backend render thread is joined before touching common objects 3. The disposing workflow of other threads than the main GPU adds commands to the command queue, causing a problem where the index can get desynced because of race conditions
These are all fixes by LotP who did not feel like creating the PR themself atm so they asked someone else to, so I am
These are all fixes by LotP who did not feel like creating the PR themself atm so they asked someone else to, so I am
Merge remote-tracking branch 'origin/lotps-fixes' into lotps-fixes
Some checks failed
Pull Request Triage / triage (pull_request_target) Successful in 1m5s
Details
Build PR / macOS Universal (Release) (pull_request) Has been cancelled
Details
Build PR / linux-arm64 (Release) (pull_request) Has been cancelled
Details
Build PR / linux-x64 (Release) (pull_request) Has been cancelled
Details
Build PR / win-arm64 (Release) (pull_request) Has been cancelled
Details
Build PR / win-x64 (Release) (pull_request) Has been cancelled
Details
1d3ff79982
Change Thread Joins Pattern Syntax
All checks were successful
Build PR / linux-arm64 (Release) (pull_request) Successful in 5m10s
Details
Build PR / win-arm64 (Release) (pull_request) Successful in 9m21s
Details
Build PR / win-x64 (Release) (pull_request) Successful in 9m21s
Details
Build PR / linux-x64 (Release) (pull_request) Successful in 9m24s
Details
Build PR / macOS Universal (Release) (pull_request) Successful in 7m12s
Details
7c3357f920
LotP merged commit e3940abe01 into master 2026-07-27 20:03:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
audio
Relates to audio emulation.

  
bug
Unintended behavior.

  
confirmed
A verified issue.

  
cpu
Related to CPU translation, missing ARMeilleure instruction, or memory.

  
critical
An issue of high importance. Should be addressed ASAP.

  
development
Related to building, upgrading dependencies, logging, or quality-of-life improvements to the development process.

  
enhancement
A new feature or enhancement to an existing one.

  
gpu
Related to GPU emulation, the shared GPU code, shader translation, or GAL.

  
graphics-backend:opengl
Related to the OpenGL backend.

  
graphics-backend:vulkan
Related to the Vulkan backend.

  
gui
A UI problem or improvement.

  
help wanted
Additional help from a more experienced developer or reverse engineer is required.

  
horizon/hle
Related to Nintendo Switch HLE components. (Ryujinx.HLE and Ryujinx.Horizon)

  
i18n
Related to translation.

  
infra
Project infrastructure; dependencies, README changes, CI script changes, etc.

  
input
Related to controller input or configuration.

  
kernel
Related to Nintendo Switch kernel functionality implemented in the HLE and Horizon projects.

  
linux
Related to a Linux-specific issue or functionality, or the appimage build.

  
macos
Related to a macOS-specific issue or functionality.

  
suggestion
A suggestion or idea for improvement.

  
windows
Related to a Windows-specific issue or functionality.

No labels
audio
bug
confirmed
cpu
critical
development
enhancement
gpu
graphics-backend:opengl
graphics-backend:vulkan
gui
help wanted
horizon/hle
i18n
infra
input
kernel
linux
macos
suggestion
windows
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
projects/Ryubing!174
No description provided.