More (UI) fixes #153

Merged

LotP merged 16 commits from Babib3l/Ryubing:ui-stuff-fixed into master 2026-08-24 21:19:22 +00:00

Conversation 1 Commits 16 Files changed 5 +203 -56

Babib3l commented 2026-06-29 22:15:44 +00:00

Contributor

• Copy link
• Copy Markdown

fixes included in this PR:

• Fix 'profile: {name}' showing as 'profile : {name}' in the Device assignement menu
• Fix changes being persisted on the default profile until another profile was loaded, which caused other small issues on other profiles
• Fix the Dropdown menu text box switching to default when another profile was saved.
• Fix an input swap persistence bug
• Fix profile saving, renaming, creation and button behaviour
• Fix the profile name being truncated too far inside the assigned devices menu
• Fixed: Profile dropdown label shifting to the left and not being aligned properly (like the rest of the labels in other dropdowns)
• Fixed: Profile dropdown options not being properly aligned (now all align left)
• Fixed: Profile dropdown label staying in the same place when making window larger
• Fixed: Profile dropdown label, when the dropdown is closed, if the label is long, gets truncated a bit too early.
• Fixed: Profile dropdown label, when the dropdown is closed, the label is very long, and you are editing the value, expanding the entire dropdown forces the text over the link icon (icon is now hidden when editing the text).
• Fixed: Pressing "Save Profile" button, after modifying a profile, doesn't make the "(Modified!)" disappear
• Fixed: Updating a linked profile (other than "Default"), pressing "Save Profile", pressing "Apply", switching to unlinked profile, pressing "Load Profile", pressing "Apply", then closing and reopening window, it'll display the linked profile label in the profile dropdown, but won't display the updated keybindings. This behaviour can be repeated in a less convoluted way, but the binding shown on initial load weren't that of the linked profile but that of the "Default" profile, and would only be shown correctly after switching to any profile and back.
• Fixed: "Reset Keybinds" button switching to the Default profile rather than remaining on currently selected profile, while not clearing bindings for that profile (must press Save Profile button for the bindings to save).

This PR won't include enabling/disabling specific buttons (Save Profile, Reset Keybinds to Default, Cancel Current Changes)' under specific conditions (i.e. when needed). This and additional UI work for the Input tab will be implemented in a dedicated Input tab PR.

Additional credits to @Neo for completing this PR while I am away. Huuuge thanks 🤗

fixes included in this PR: - Fix 'profile: {name}' showing as 'profile : {name}' in the Device assignement menu - Fix changes being persisted on the default profile until another profile was loaded, which caused other small issues on other profiles - Fix the Dropdown menu text box switching to default when another profile was saved. - Fix an input swap persistence bug - Fix profile saving, renaming, creation and button behaviour - Fix the profile name being truncated too far inside the assigned devices menu - Fixed: Profile dropdown label shifting to the left and not being aligned properly (like the rest of the labels in other dropdowns) - Fixed: Profile dropdown options not being properly aligned (now all align left) - Fixed: Profile dropdown label staying in the same place when making window larger - Fixed: Profile dropdown label, when the dropdown is closed, if the label is long, gets truncated a bit too early. - Fixed: Profile dropdown label, when the dropdown is closed, the label is very long, and you are editing the value, expanding the entire dropdown forces the text over the link icon (icon is now hidden when editing the text). - Fixed: Pressing "Save Profile" button, after modifying a profile, doesn't make the "(Modified!)" disappear - Fixed: Updating a linked profile (other than "Default"), pressing "Save Profile", pressing "Apply", switching to unlinked profile, pressing "Load Profile", pressing "Apply", then closing and reopening window, it'll display the linked profile label in the profile dropdown, but won't display the updated keybindings. This behaviour can be repeated in a less convoluted way, but the binding shown on initial load weren't that of the linked profile but that of the "Default" profile, and would only be shown correctly after switching to any profile and back. - Fixed: "Reset Keybinds" button switching to the Default profile rather than remaining on currently selected profile, while not clearing bindings for that profile (must press Save Profile button for the bindings to save). This PR won't include enabling/disabling specific buttons (Save Profile, Reset Keybinds to Default, Cancel Current Changes)' under specific conditions (i.e. when needed). This and additional UI work for the Input tab will be implemented in a dedicated Input tab PR. Additional credits to @Neo for completing this PR while I am away. Huuuge thanks 🤗

ryubing-ci added the

gui

i18n

input

labels 2026-06-29 22:16:06 +00:00

Ghost added this to the 1.4.0 milestone 2026-06-30 17:59:43 +00:00

Babib3l force-pushed ui-stuff-fixed from 6a9d131b53 to 1e0cf38a5f 2026-06-30 18:49:59 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from cf92efdf18 to 863562ca83 2026-07-04 14:17:42 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from 863562ca83 to 509f96b96f 2026-07-08 18:22:31 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from 509f96b96f to fb7cafa33c 2026-07-10 12:11:50 +00:00 Compare

Neo force-pushed ui-stuff-fixed from fb7cafa33c to d81e0dfe3f 2026-07-13 20:32:30 +00:00 Compare

Neo force-pushed ui-stuff-fixed from c6bee312cd to 1c3aafc7f1 2026-07-17 01:30:55 +00:00 Compare

Neo commented 2026-07-17 01:48:06 +00:00

Contributor

• Copy link
• Copy Markdown

Additional commits address the following:

• Fixed: Profile dropdown label shifting to the left and not being aligned properly (like the rest of the labels in other dropdowns)
• Fixed: Profile dropdown options not being properly aligned (now all align left)
• Fixed: Profile dropdown label staying in the same place when making window larger
• Fixed: Profile dropdown label, when the dropdown is closed, if the label is long, gets truncated a bit too early.
• Fixed: Profile dropdown label, when the dropdown is closed, the label is very long, and you are editing the value, expanding the entire dropdown forces the text over the link icon (icon is now hidden when editing the text).
• Fixed: Pressing "Save Profile" button, after modifying a profile, doesn't make the "(Modified!)" disappear
• Fixed: Updating a linked profile (other than "Default"), pressing "Save Profile", pressing "Apply", switching to unlinked profile, pressing "Load Profile", pressing "Apply", then closing and reopening window, it'll display the linked profile label in the profile dropdown, but won't display the updated keybindings. This behaviour can be repeated in a less convoluted way, but the binding shown on initial load weren't that of the linked profile but that of the "Default" profile, and would only be shown correctly after switching to any profile and back.
• Fixed: "Reset Keybinds" button switching to the Default profile rather than remaining on currently selected profile, while not clearing bindings for that profile (must press Save Profile button for the bindings to save).

This PR won't include enabling/disabling specific buttons (Save Profile, Reset Keybinds to Default, Cancel Current Changes)' under specific conditions (i.e. when needed). This and additional UI work for the Input tab will be implemented in a dedicated Input tab PR.

Additional commits address the following: - **Fixed:** Profile dropdown label shifting to the left and not being aligned properly (like the rest of the labels in other dropdowns) - **Fixed:** Profile dropdown options not being properly aligned (now all align left) - **Fixed:** Profile dropdown label staying in the same place when making window larger - **Fixed:** Profile dropdown label, when the dropdown is closed, if the label is long, gets truncated a bit too early. - **Fixed:** Profile dropdown label, when the dropdown is closed, the label is very long, and you are editing the value, expanding the entire dropdown forces the text over the link icon (icon is now hidden when editing the text). - **Fixed:** Pressing "Save Profile" button, after modifying a profile, doesn't make the "(Modified!)" disappear - **Fixed:** Updating a linked profile (other than "Default"), pressing "Save Profile", pressing "Apply", switching to unlinked profile, pressing "Load Profile", pressing "Apply", then closing and reopening window, it'll display the linked profile label in the profile dropdown, but won't display the updated keybindings. This behaviour can be repeated in a less convoluted way, but the binding shown on initial load weren't that of the linked profile but that of the "Default" profile, and would only be shown correctly after switching to any profile and back. - **Fixed:** "Reset Keybinds" button switching to the Default profile rather than remaining on currently selected profile, while not clearing bindings for that profile (must press Save Profile button for the bindings to save). This PR won't include enabling/disabling specific buttons (Save Profile, Reset Keybinds to Default, Cancel Current Changes)' under specific conditions (i.e. when needed). This and additional UI work for the Input tab will be implemented in a dedicated Input tab PR.

Babib3l changed title from WIP: More (UI) fixes to More (UI) fixes 2026-07-17 18:04:26 +00:00

Babib3l force-pushed ui-stuff-fixed from 1c3aafc7f1 to 5756546d96 2026-07-17 18:04:39 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from 5756546d96 to c4f14587c1 2026-07-27 20:12:46 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from c4f14587c1 to a2c39d308d 2026-07-30 22:10:49 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from a2c39d308d to c61af693e1 2026-08-17 11:43:39 +00:00 Compare

Babib3l force-pushed ui-stuff-fixed from c61af693e1 to e2ec4d727f 2026-08-24 18:55:55 +00:00 Compare

LotP force-pushed ui-stuff-fixed from e2ec4d727f to b77b7dddd3 2026-08-24 21:03:33 +00:00 Compare

LotP merged commit 2b6e077918 into master 2026-08-24 21:19:22 +00:00

LotP referenced this pull request from a commit 2026-08-24 21:19:23 +00:00

More (UI) fixes (#153)

Sign in to join this conversation.

Reviewers

No reviewers

Ghost

Labels

Clear labels   

audio

Relates to audio emulation.

  

bug

Unintended behavior.

  

confirmed

A verified issue.

  

cpu

Related to CPU translation, missing ARMeilleure instruction, or memory.

  

critical

An issue of high importance. Should be addressed ASAP.

  

development

Related to building, upgrading dependencies, logging, or quality-of-life improvements to the development process.

  

enhancement

A new feature or enhancement to an existing one.

  

gpu

Related to GPU emulation, the shared GPU code, shader translation, or GAL.

  

graphics-backend:opengl

Related to the OpenGL backend.

  

graphics-backend:vulkan

Related to the Vulkan backend.

  

gui

A UI problem or improvement.

  

help wanted

Additional help from a more experienced developer or reverse engineer is required.

  

horizon/hle

Related to Nintendo Switch HLE components. (Ryujinx.HLE and Ryujinx.Horizon)

  

i18n

Related to translation.

  

infra

Project infrastructure; dependencies, README changes, CI script changes, etc.

  

input

Related to controller input or configuration.

  

kernel

Related to Nintendo Switch kernel functionality implemented in the HLE and Horizon projects.

  

linux

Related to a Linux-specific issue or functionality, or the appimage build.

  

macos

Related to a macOS-specific issue or functionality.

  

suggestion

A suggestion or idea for improvement.

  

windows

Related to a Windows-specific issue or functionality.

No labels

audio

bug

confirmed

cpu

critical

development

enhancement

gpu

graphics-backend:opengl

graphics-backend:vulkan

gui

help wanted

horizon/hle

i18n

infra

input

kernel

linux

macos

suggestion

windows

Milestone

Clear milestone

No items

No milestone

1.4.0

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference

projects/Ryubing!153

No description provided.