UI: Add random splashes to loading screen #128
No reviewers
Labels
No labels
audio
bug
confirmed
cpu
critical
development
enhancement
gpu
graphics-backend:opengl
graphics-backend:vulkan
gui
help wanted
horizon/hle
i18n
infra
input
kernel
linux
macos
suggestion
windows
No assignees
2 participants
Notifications
Due date
No due date set.
Reference
projects/Ryubing!128
Loading…
Reference in a new issue
No description provided.
Delete branch "RecursiveMemory/Ryujinx:SplashText"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR introduces splash text messages that change per startup on the loading screen after selecting a game. It also moves the "RYUBING" logo splash in logs to be inside its own class, which also handles loading screen splashes and titlebar splashes. Credits to VewDev, Lotp, Sh0inx, yell0wsuit, and Greemdev for pointers and assistance throughout this PR.
Take a look at some of the comments I have for you. Once you've addressed everything here, give me a holler on Discord or whatever and we can work on getting it merged.
@ -0,0 +54,4 @@"How do you people do anything?","One dollar.","Somebody once told me!","Its that time of the month again!",Update this to "It's that time of the year again!" please. I know it isn't intentional, but this can be read as a reference to menstruation, which isn't appropriate for our software and can be considered offensive.
@ -0,0 +61,4 @@":3",":3",":3",":3",Seems like you might have missed a couple of commits, check your git history. I remember these were replaced with a reference to self-replication.
@ -0,0 +68,4 @@"Ganon is watching you!","Now with 100% more JSON in the splash code!","Countless hours of fun!","Sorry, Link. I can't give credit. Come back when you're a little... mmmmmm ...richer!",Space should be after the ellipses.
"Sorry, Link. I can't give credit. Come back when you're a little... mmmmmm... richer!"@ -0,0 +73,4 @@"You've met with a terrible fate, haven't you?","Yahaha! You found me!","I would've been in real trouble if you hadn't shown up when you did, goro.","Stay fresh.",Modify
"Stay fresh."to use an exclamation mark and add this one:"Don't get cooked, stay off the hook!"@ -0,0 +7,4 @@namespace Ryujinx.Common{// My code is crappy and I know it. Props to VewDev for assisting me in these shenanigans. - AwesomeangottiYour code isn't crappy. You might be a beginner, but you're learning fast. Remove this comment, we don't need negativity in our codebase.
@ -31,2 +31,2 @@? $"{FullAppName}{(includeVersion ? $" {Program.Version}" : string.Empty)}": $"{FullAppName}{(includeVersion ? $" {Program.Version}" : string.Empty)} - {LocaleManager.Instance[windowTitleKey.Value]}";? $"{FullAppName}{(includeVersion ? $" {Program.Version}" : string.Empty)}{SplashTextHelper.GetTitleSplash()}": $"{FullAppName}{(includeVersion ? $" {Program.Version}" : string.Empty)} - {LocaleManager.Instance[windowTitleKey.Value]}{SplashTextHelper.GetTitleSplash()}";I thought we talked about not including the splash in the title bar?
Me when I type stubfolder instead of subfolder
7afeab2dde304dd2cc8aUI: Add random splashes to loading screento WIP: UI: Add random splashes to loading screenDO NOT MERGE THIS YET ITS SO COOKED
WIP: UI: Add random splashes to loading screento UI: Add random splashes to loading screen@ -1262,2 +1265,3 @@case ShaderCacheLoadingState.Loading:LoadHeading = LocaleManager.Instance[LocaleKeys.CompilingShaders];//LoadHeading = LocaleManager.Instance[LocaleKeys.CompilingShaders]; This is the original line. Leaving it here until done.LoadHeading = $"{LocaleManager.Instance[LocaleKeys.CompilingShaders]} - {SplashTextHelper.GetSplash()}";I thought we decided to place the splash text below the compilation line?
Should be good to do now : )