Skip to content
Snippets Groups Projects
Forked from Ryubing / Ryujinx
Source project has a limited visibility.
  • riperiperi's avatar
    ca59c3f4
    Vulkan: Feedback loop detection and barriers (#7226) · ca59c3f4
    riperiperi authored
    * Vulkan: Feedback loop improvements
    
    This PR allows the Vulkan backend to detect attachment feedback loops. These are currently used in the following ways:
    
    - Partial use of VK_EXT_attachment_feedback_loop_layout
      - All renderable textures have AttachmentFeedbackLoopBitExt
      - Compile pipelines with Color/DepthStencil feedback loop flags when present
    - Support using FragmentBarrier for feedback loops (fixes regressions from https://github.com/Ryujinx/Ryujinx/pull/7012 )
    
    TODO:
    - AMD GPUs may need layout transitions for it to properly allow textures to be used in feedback loops.
    - Use dynamic state for feedback loops. The background pipeline will always miss since feedback loop state isn't known on the GPU project.
    - How is the barrier dependency flag used? (DXVK just ignores it, there's no vulkan validation...)
    - Improve subpass dependencies to fix validation errors
    
    * Mark field readonly
    
    * Add feedback loop dynamic state
    
    * fix: add MoltenVK resolver workaround
    
    fix: add MoltenVK resolver workaround
    
    * Formatting
    
    * Fix more complaints
    
    * RADV dcc workaround
    
    * Use dynamic state properly, cleanup.
    
    * Use aspects flags in more places
    Vulkan: Feedback loop detection and barriers (#7226)
    riperiperi authored
    * Vulkan: Feedback loop improvements
    
    This PR allows the Vulkan backend to detect attachment feedback loops. These are currently used in the following ways:
    
    - Partial use of VK_EXT_attachment_feedback_loop_layout
      - All renderable textures have AttachmentFeedbackLoopBitExt
      - Compile pipelines with Color/DepthStencil feedback loop flags when present
    - Support using FragmentBarrier for feedback loops (fixes regressions from https://github.com/Ryujinx/Ryujinx/pull/7012 )
    
    TODO:
    - AMD GPUs may need layout transitions for it to properly allow textures to be used in feedback loops.
    - Use dynamic state for feedback loops. The background pipeline will always miss since feedback loop state isn't known on the GPU project.
    - How is the barrier dependency flag used? (DXVK just ignores it, there's no vulkan validation...)
    - Improve subpass dependencies to fix validation errors
    
    * Mark field readonly
    
    * Add feedback loop dynamic state
    
    * fix: add MoltenVK resolver workaround
    
    fix: add MoltenVK resolver workaround
    
    * Formatting
    
    * Fix more complaints
    
    * RADV dcc workaround
    
    * Use dynamic state properly, cleanup.
    
    * Use aspects flags in more places
Code owners
Assign users and groups as approvers for specific file changes. Learn more.